feat: add delegation with storage griefing guard to governance#648
Merged
greatest0fallt1me merged 1 commit intoJun 27, 2026
Conversation
- Add set_delegate/unset_delegate/get_delegate with three-layer guard: 1. One active delegation per delegator (must unset before re-delegating) 2. Incoming cap (MAX_INCOMING_DELEGATIONS=50) tracked via DelegateCount 3. Self-delegation and two-hop cycle detection - vote() applies delegated weight (O(1) DelegateCount read, no iteration) - 10 new tests covering all guard conditions and weighted vote behaviour - Uncomment mod governance_tests in lib.rs Closes Predictify-org#256
muffti123
added a commit
to muffti123/predictify-contracts
that referenced
this pull request
Jun 28, 2026
Implements an admin-only force_resolve_market entrypoint on the PredictifyHybrid contract that can resolve a market BEFORE its end_time, with strict idempotency-key replay protection. Closes Predictify-org#648 === API Changes === New function: force_resolve_market(env, admin, market_id, winning_outcomes, reason, idempotency_key) -> Result<(), Error> Key differences from existing resolve_market_manual: - Bypasses end_time check (resolves at any time) - Returns Result<(), Error> instead of panicking - Requires non-empty 'reason' (stored in audit trail) - Requires a unique idempotency_key (string, e.g. UUID) per market - Supports multiple winning outcomes (Vec<String>) === New Error Codes === ForceResolveReplayed (517) - idempotency key already used ForceResolveReasonEmpty (518) - empty reason string === New Events === ForceResolvedEvent (topic 'frc_rs') emitted on success === New Audit Action === AuditAction::MarketForceResolved === New Module === force_resolve.rs - ForceResolveManager for idempotency storage === Files === M src/err.rs - error variants, classification, recovery M src/events.rs - event struct + ForceResolvedEvent emitter M src/lib.rs - force_resolve_market function + test mod M src/audit_trail.rs - MarketForceResolved audit action A src/force_resolve_tests.rs - comprehensive tests
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #628
Closes #256
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀